Skip to content

Conversation

@momesgin
Copy link
Member

@momesgin momesgin commented Nov 14, 2025

Summary

Fixes #15885

Occurred changes and/or fixed issues

Fixed the alignement issue with the underline styling of the icon and the text for back to home link.

Technical notes summary

Added a span tag around the text and adjusted underline styling on both the icon and the text to align them.

Areas or cases that should be tested

Go to Preferences page, hover on the Home link and make sure the chevron icon and the home text both have an aligned underline styling

Areas which could experience regressions

Most likely none.

Screenshot/Video

image image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@momesgin momesgin added this to the v2.14.0 milestone Nov 14, 2025
@momesgin momesgin self-assigned this Nov 14, 2025
@momesgin momesgin added the QA/manual-test Indicates issue requires manually testing label Nov 14, 2025
@momesgin momesgin marked this pull request as ready for review November 14, 2025 19:58
@eva-vashkevich
Copy link
Member

A bit of a nitpic, does the underline look too long at the front? It's likely because of the paddings on the icon. Just wanted to not it.
Screenshot 2025-11-17 at 11 57 23 AM

@momesgin
Copy link
Member Author

A bit of a nitpic, does the underline look too long at the front? It's likely because of the paddings on the icon. Just wanted to not it. Screenshot 2025-11-17 at 11 57 23 AM

Padding doesn't work like that with text-decoration: underline but with borders which I switched to.

padding: 0 4px 2px 0;
outline: 0;
width: fit-content;
border-bottom: 2px solid transparent;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to prevent layout shifting

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momesgin momesgin merged commit d474734 into rancher:master Nov 17, 2025
37 checks passed
@momesgin momesgin deleted the 15885-back-to-home-link branch November 17, 2025 21:55
@momesgin momesgin modified the milestones: v2.14.0, v2.13.0 Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA/manual-test Indicates issue requires manually testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual issue with the home link on Preferences page

2 participants